git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] Convert simple init_pathspec() cases to parse_pathspec()

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 13, 2011, 00:29 UTC
Message-ID
<7vbotl7mzv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1318373083-13840-6-git-send-email-pclouds@gmail.com>

I gave a cursory look up to this one. I didn't read 4/6 very carefully though.

I think teaching the users of "raw[]" field of "struct pathspec" to use corresponding "items[]" element should come before this series (up to 5/6). After that, once parse_pathspec() API stabilizes, we should teach users of get_pathspec() to get and pass around "struct pathspec" and when we reach the point where we can get rid of use of "raw[]" field (the field itself can stay to serve as a debugging aid if we choose to), everybody that uses pathspec would be ready to start taking more magic pathspecs.

Having said that, I think the series itself is going in the right direction.

Thanks for working on this.
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 10 of 12 in “Negation magic pathspec”
  1. 0/6 Negation magic pathspecNguyễn Thái Ngọc Duy, Oct 11, 2011
  2. 1/6 Recognize magic pathspec as filenamesNguyễn Thái Ngọc Duy, Oct 11, 2011
  3. Junio C HamanoOct 12, 2011
  4. Nguyen Thai Ngoc DuyOct 13, 2011
  5. Junio C HamanoOct 13, 2011
  6. 2/6 Replace has_wildcard with PATHSPEC_NOGLOBNguyễn Thái Ngọc Duy, Oct 11, 2011
  7. 3/6 Convert prefix_pathspec() to produce struct pathspec_itemNguyễn Thái Ngọc Duy, Oct 11, 2011
  8. 4/6 Implement parse_pathspec()Nguyễn Thái Ngọc Duy, Oct 11, 2011
  9. 5/6 Convert simple init_pathspec() cases to parse_pathspec()Nguyễn Thái Ngọc Duy, Oct 11, 2011
  10. Junio C HamanoOct 13, 2011
  11. 6/6 Implement negative pathspecNguyễn Thái Ngọc Duy, Oct 11, 2011
  12. Junio C HamanoOct 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.