From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 13 Oct 2011 00:29:08 GMT
Subject: Re: [PATCH 5/6] Convert simple init_pathspec() cases to parse_pathspec()
Message-ID: <7vbotl7mzv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1318373083-13840-6-git-send-email-pclouds@gmail.com>

I gave a cursory look up to this one. I didn't read 4/6 very carefully
though.

I think teaching the users of "raw[]" field of "struct pathspec" to use
corresponding "items[]" element should come before this series (up to
5/6). After that, once parse_pathspec() API stabilizes, we should teach
users of get_pathspec() to get and pass around "struct pathspec" and when
we reach the point where we can get rid of use of "raw[]" field (the field
itself can stay to serve as a debugging aid if we choose to), everybody
that uses pathspec would be ready to start taking more magic pathspecs.

Having said that, I think the series itself is going in the right
direction.

Thanks for working on this.