git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2013, 17:25 UTC
Message-ID
<7vbo6e5ljs.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130707040337.GA30898@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> Before, if (!one && !two) we would call contains(two, ...), and now we
> will simply assume it is zero. Which I think is an improvement, as we
> would have segfaulted before. I don't think it is a bug in the current
> code (we would not ever feed the function two NULLs), but it is nice to
> be more defensive.
>
> Acked-by: Jeff King <peff@peff.net>
Thanks, both.
Previous: Jeff King
Message 3 of 3 in “diffcore-pickaxe: simplify has_changes and contains”
  1. diffcore-pickaxe: simplify has_changes and containsRené Scharfe, Jul 6, 2013
  2. Jeff KingJul 7, 2013
  3. Junio C HamanoJul 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.