From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 07 Jul 2013 17:25:59 GMT
Subject: Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains
Message-ID: <7vbo6e5ljs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130707040337.GA30898@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Before, if (!one && !two) we would call contains(two, ...), and now we
> will simply assume it is zero. Which I think is an improvement, as we
> would have segfaulted before. I don't think it is a bug in the current
> code (we would not ever feed the function two NULLs), but it is nice to
> be more defensive.
>
> Acked-by: Jeff King <peff@peff.net>

Thanks, both.