Re: Usage of isspace and friends

> Someone needs to audit the usage of isspace, tolower, and
> friends.  There are things like this in the code:
>
> static int is_dev_null(const char *str)
> {
> 	return !memcmp("/dev/null", str, 9) && isspace(str[9]);
> }
>
> Since str[9] is of type char it should not be used as a argument to
> isspace directly,
> but rather be cast to unsigned char:
>
>     ... isspace((unsigned char)str[9]);