git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Usage of isspace and friends

From
HAH. Peter Anvin <hpa@zytor.com>
Date
Oct 13, 2005, 13:27 UTC
Message-ID
<434E60AB.8030607@zytor.com>
In-Reply-To
<7vachd6hdx.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 10 quoted lines
> 
> Huh?  isspace is "int isspace(int)".  Presumably standard
> integral promotion rules applies here whether char is signed or
> unsigned, doesn't it?
> 
> The snippet you quoted is from apply.c, and I would say what is
> more problematic is that we do not force C locale while parsing
> the diff (see another thread -- we would want to process diffs
> as byte streams).
>

The problem is that isspace() is defined to operate on an integer which can be an unsigned char value promoted to int or EOF (-1).

	-hpa
Previous: Antti-Juhani KaijanahoNext: Junio C Hamano
Message 4 of 10 in “Usage of isspace and friends”
  1. Morten WelinderOct 12, 2005
  2. Junio C HamanoOct 13, 2005
  3. Antti-Juhani KaijanahoOct 13, 2005
  4. H. Peter AnvinOct 13, 2005
  5. Junio C HamanoOct 13, 2005
  6. Linus TorvaldsOct 13, 2005
  7. H. Peter AnvinOct 13, 2005
  8. Linus TorvaldsOct 13, 2005
  9. H. Peter AnvinOct 13, 2005
  10. Linus TorvaldsOct 13, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.