Re: [PATCH] gitweb.css: Courer fonts for commits and tree-diff

From: Junio C Hamano <junkio@cox.net>
Date: Jul 12, 2006, 06:02 UTC
Message-ID: <7vac7f1htw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060712034323.48414.qmail@web31806.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

> Courer fonts for the commit header, commit message,
> and tree-diff.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

I really do not want to be in the position to judge a patch like this, whose evaluation is solely based on "prettiness" factor.

But if I really have to, I would say this makes things uglier and less readable. Maybe asking for monospace is less yucky but naming Courier explicitly?

BTW what tool do you use to generate and send your patches? I remember another patch from you recently did not apply and it turned out the problem was that the last hunk had line numbers wrong. This patch has exactly the same problem and I am wondering why.

I count 10 lines of original and 15 lines of new material in this hunk but the hunk header claims to have 11 lines of original text.

---
 gitweb/gitweb.css |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 98410f5..b51282b 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
 ... 
@@ -142,11 +144,15 @@ table {
 	padding: 8px 4px;
 }
 
-table.project_list, table.diff_tree {
+table.project_list {
 	border-spacing: 0;
 }
 
+table.diff_tree {
+	border-spacing: 0;
+	font-family: courier;
+}
+
 table.blame {
 	border-collapse: collapse;
 }

-- 
1.4.1.g9ca3