Re: [PATCH] gitweb.css: Courer fonts for commits and tree-diff

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Jul 12, 2006, 17:46 UTC
Message-ID: <20060712174610.71046.qmail@web31810.mail.mud.yahoo.com>
In-Reply-To: <7vac7f1htw.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:

Show 13 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Courer fonts for the commit header, commit message,
> > and tree-diff.
> >
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> I really do not want to be in the position to judge a patch like
> this, whose evaluation is solely based on "prettiness" factor.
> 
> But if I really have to, I would say this makes things uglier
> and less readable.  Maybe asking for monospace is less yucky but
> naming Courier explicitly?

Sometimes people would put ASCII art in their commit messages, things like a simple table, compiler output, log output, etc, and I wanted to _preserve_ the intent of such output. This is why I changed it to Courier. (sorry for the misspelling of Courier)

Show 5 quoted lines

> BTW what tool do you use to generate and send your patches?  I
> remember another patch from you recently did not apply and it
> turned out the problem was that the last hunk had line numbers
> wrong.  This patch has exactly the same problem and I am
> wondering why.

I use git. Those patches are against a one-off branch, which I created for the purpose of sending you the patches.

The original patches are against my "git-lt" branch, which has the File::MMagic changes in it -- it is my working branch. So I generated a patch off of "git-lt", applied it to "one-off-gitweb", which is identical to the git "master" branch, and sent the patches.

      Luben

Show 39 quoted lines

> 
> I count 10 lines of original and 15 lines of new material in
> this hunk but the hunk header claims to have 11 lines of
> original text.
> 
> ---
>  gitweb/gitweb.css |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 98410f5..b51282b 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
>  ... 
> @@ -142,11 +144,15 @@ table {
>  	padding: 8px 4px;
>  }
>  
> -table.project_list, table.diff_tree {
> +table.project_list {
>  	border-spacing: 0;
>  }
>  
> +table.diff_tree {
> +	border-spacing: 0;
> +	font-family: courier;
> +}
> +
>  table.blame {
>  	border-collapse: collapse;
>  }
> -- 
> 1.4.1.g9ca3
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>