Re: [PATCH] Use "-f" when adding files with odd names in t9200.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 3, 2007, 20:51 UTC
Message-ID: <7vabzv3qxi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <F16FE131-CF33-4DD0-9A06-4A24C59C7623@silverinsanity.com>

Brian Gernhardt <benji@silverinsanity.com> writes:

> The only solution I can think of is to make dir.c:match_one() unicode-
> aware.  Which I'm working on to see if it will work, but don't know if
> you want to include that complication.

A filesystem that reports success on creat(path) and then does not return that path to later readdir() from that directory is broken from git's point of view. At least that has been the definition so far.

I am not sure offhand the implications of the change you propose to make to match_one(), but it could also be the place to handle case-challenged filesystems.

But even if you do that, I wonder what your plan would be to handle something like "git add .". read_directory_recursive() asks readdir() for existing pathnames, and we expect that can be used as parameter to add_file_to_index and then eventually we can call creat() or symlink() with it, so it also needs to be taught to behave consistently with respect to what your updated match_one() does.