Re: [PATCH] Use "-f" when adding files with odd names in t9200.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 3, 2007, 19:42 UTC
Message-ID: <7v4pq358q4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070203181329.GA10192@179.242.249.10.in-addr.arpa>

Brian Gernhardt <benji@silverinsanity.com> writes:

Show 9 quoted lines

> Without -f, the UTF-8 named files are ignored (supposedly via
> .gitignore) on systems with a different UTF-8 encoding.
> This patch makes the test pass on OS X on HFS+, in particular.
>
> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
> ---
>  
>  I still think that the behavior of git-add here is an error.  The file
>  is NOT in any ignore file and so should not be marked as such.

Can you describe why git-add finds the (presumably mangled by HFS) path in ".gitignore"? If we had some default pattern in info/exclude that is installed in the trash test repository I would understand that a mangled path could happen to match it, but I do not think we do not have any exclude pattern by default.

Unless/until you know why git-add thinks it is ignored,...

>  However,
>  this allows me to finally use "make test && sudo make install".

... I think this change means you are installing something the existing test knows to be broken, which is not very pretty.