git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9400: Use the repository config and nothing else.

From
Junio C Hamano <junkio@cox.net>
Date
May 12, 2007, 16:31 UTC
Message-ID
<7vabwa3swp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070512162819.GA7184@planck.djpig.de>
Frank Lichtenheld <frank@lichtenheld.de> writes:
Show 9 quoted lines
> On Fri, May 11, 2007 at 04:35:18PM -0700, Junio Hamano wrote:
>> This needs to be fixed, but thanks to that bug, a separate bug
>> in t9400 test script was discovered.  The test discarded
>> GIT_CONFIG instead of pointing at the proper one to be used in
>> the exoprted repository.  This allowed user's .gitconfig and (if
>> exists) systemwide /etc/gitconfig to affect the outcome of the
>> test, which is a big no-no.
>
> Shouldn't you also remove the "unset GIT_CONFIG" then?

I didn't test the side of the test that works on the git side, but I think you are right.

Previous: Frank LichtenheldNext: Junio C Hamano
Message 3 of 11 in “t9400: Use the repository config and nothing else.”
  1. t9400: Use the repository config and nothing else.Junio Hamano, May 11, 2007
  2. Frank LichtenheldMay 12, 2007
  3. Junio C HamanoMay 12, 2007
  4. Junio C HamanoMay 12, 2007
  5. Frank LichtenheldMay 12, 2007
  6. cvsserver: Complete rewrite of the configuration parserFrank Lichtenheld, May 12, 2007
  7. Junio C HamanoMay 12, 2007
  8. Frank LichtenheldMay 12, 2007
  9. Junio C HamanoMay 12, 2007
  10. cvsserver: Limit config parser to needed optionsFrank Lichtenheld, May 13, 2007
  11. Junio C HamanoMay 13, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.