From: Junio C Hamano <junkio@cox.net>
Date: Sat, 12 May 2007 16:31:34 GMT
Subject: Re: [PATCH] t9400: Use the repository config and nothing else.
Message-ID: <7vabwa3swp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070512162819.GA7184@planck.djpig.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

> On Fri, May 11, 2007 at 04:35:18PM -0700, Junio Hamano wrote:
>> This needs to be fixed, but thanks to that bug, a separate bug
>> in t9400 test script was discovered.  The test discarded
>> GIT_CONFIG instead of pointing at the proper one to be used in
>> the exoprted repository.  This allowed user's .gitconfig and (if
>> exists) systemwide /etc/gitconfig to affect the outcome of the
>> test, which is a big no-no.
>
> Shouldn't you also remove the "unset GIT_CONFIG" then?

I didn't test the side of the test that works on the git side,
but I think you are right.