Re: [PATCH] fix parallel make problem

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2007, 08:12 UTC
Message-ID: <7vabs82kcq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20070831080651.GA17637@mellanox.co.il>

"Michael S. Tsirkin" <mst@dev.mellanox.co.il> writes:

Show 6 quoted lines

>> +.PRECIOUS: $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))
>> +
>>  test-%$X: test-%.o $(GITLIBS)
>>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS)
>
> Add a comment here?

I did not see a particular need for that. What would you say there?

>> Warning: 1 path touched but unmodified. Consider running git-status.
>
> BTW, shouldn't the warning go to standard error?

No, usually you are under PAGER, so we need to send this to stdout. We do this only when we are generating textual diff which will be consumed by patch or git-apply. They both know how to ignore such a non patch material.