Re: [PATCH] fix parallel make problem

From: Jeff King <peff@peff.net>
Date: Aug 31, 2007, 16:03 UTC
Message-ID: <20070831160335.GA17761@coredump.intra.peff.net>
In-Reply-To: <7vr6lj1zg3.fsf@gitster.siamese.dyndns.org>

On Fri, Aug 31, 2007 at 08:44:12AM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> I did not even want to apply that "empty diff --git removal"
> patch.  I certainly do _NOT_ want to suppress that replacement
> warning anywhere.
> 
> You are seriously tempting me to revert the commit
> fb13227e089f22dc31a3b1624559153821056848 (git-diff: squelch
> "empty" diffs)...

FWIW, I find the new message terribly ugly compared to the old behavior. There have been many output changes that I didn't like at first, but for which I held my tongue and eventually grew to like when they became more familiar (e.g., the 'subject' line after git-commit).

But I just can't seem to find this one anything but ugly; everytime I see it, I involuntarily cringe. Perhaps because it really looks like an error message that accidentally got stuck in the diff output through incompetent redirection of stdout/stderr.

I say this not to start a flame war (which is perhaps inevitable), but I just wonder if others feel the same, now that they have had a chance to get used to it.

-Peff