Re: [PATCH/RFC] Use regex for :/ matching
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 6, 2007, 06:33 UTC
- Message-ID
- <7vaboogwmq.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071206055200.GA23309@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> Obviously the overall design and usage of :/ is going to take some > thinking and is not 1.5.4 material. However, we do have it in its > current form, and I think regex versus prefix string matching is > orthogonal to the range issues. Should I post my rebased :/ regex patch, > or do you want to just leave it for post-1.5.4?
Making what was string match to regex using the same syntax is a regression, isn't it? I do not use :/ very often myself, so I personally would not mind but people who are used to using :/ may get upset about the change. I do not feel strongly enough for changing it to regex to declare such a change unilaterally.