Re: [PATCH/RFC] Use regex for :/ matching

From: Jeff King <peff@peff.net>
Date: Dec 6, 2007, 05:52 UTC
Message-ID: <20071206055200.GA23309@coredump.intra.peff.net>
In-Reply-To: <7vbq97iqxd.fsf@gitster.siamese.dyndns.org>

On Mon, Dec 03, 2007 at 10:17:18AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> So in short:
> 
>  * I do not think extending it to mean a set of commits (with some
>    definition of how the set is computed) is a good idea.  It can stay
>    "name one commit that matches this string" without losing usefulness,
>    and I think it should;
> 
>  * The definition of the "match" can be tweaked and introducing regexp
>    might be a good way;
> 
>  * The definition of the "match" may become more useful if we can limit
>    which refs to dig from.

Obviously the overall design and usage of :/ is going to take some thinking and is not 1.5.4 material. However, we do have it in its current form, and I think regex versus prefix string matching is orthogonal to the range issues. Should I post my rebased :/ regex patch, or do you want to just leave it for post-1.5.4?

-Peff