Re: [PATCH] Include rev-list options in git-log manpage.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2008, 19:50 UTC
- Message-ID
- <7vabn2ewv7.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080118171827.GV29972@genesis.frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> writes:
Show 5 quoted lines
> +ifndef::git-log[] > Using these options, linkgit:git-rev-list[1] will act similar to the > more specialized family of commit log tools: linkgit:git-log[1], > linkgit:git-show[1], and linkgit:git-whatchanged[1] > +endif::git-log[]
Show 9 quoted lines
> +ifndef::git-log[] > --bisect:: > > Limit output to the one commit object which is roughly halfway between > @@ -388,6 +302,7 @@ may not compile for example). > This option can be used along with `--bisect-vars`, in this case, > after all the sorted commit objects, there will be the same text as if > `--bisect-vars` had been used alone. > +endif::git-log[]
I do not like these. What you are really trying to express is "this section makes sense only in rev-list documentation", not "the current set of documentation this section does not make sese is git-log". We might end up including this in some other documents.
IOW, they should rather be "ifdef::git-rev-list[]" instead.