Re: [PATCH] Include rev-list options in git-log manpage.
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jan 18, 2008, 16:37 UTC
- Message-ID
- <4790D5B7.2000508@viscovery.net>
- In-Reply-To
- <20080118161714.GS29972@genesis.frugalware.org>
Miklos Vajna schrieb:
Show 5 quoted lines
> Documentation/git-log.txt | 6 +- > Documentation/git-rev-list.txt | 358 +----------------------------------- > Documentation/rev-list-options.txt | 364 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 367 insertions(+), 361 deletions(-) > create mode 100644 Documentation/rev-list-options.txt
Had you used format-patch -C then the patch would have been shorter by ~240 lines. And it would have been immediately obvious that you have put this inside ifndef::gitlog[] brackets:
Show 10 quoted lines
> +ifndef::git-log[] > +--first-parent:: > + Follow only the first parent commit upon seeing a merge > + commit. This option can give a better overview when > + viewing the evolution of a particular topic branch, > + because merges into a topic branch tend to be only about > + adjusting to updated upstream from time to time, and > + this option allows you to ignore the individual commits > + brought in to your history by such a merge. > +endif::git-log[]
I wonder why these brackets are necessary. This text applies to git-log, too, no? Can't you just remove that paragraph from git-log.txt?
-- Hannes