git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http.c: guard config parser from value=NULL

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 9, 2008, 21:09 UTC
Message-ID
<7vabm9et0x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com>
"Govind Salinas" <blix@sophiasuchtig.com> writes:
Show 19 quoted lines
> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
> ---
>  http.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
>  static int http_options(const char *var, const char *value)
>  {
> +	if (!value)
> +		return git_default_config(var, value);
> +
>  	if (!strcmp("http.sslverify", var)) {
>  		if (curl_ssl_verify == -1) {
>  			curl_ssl_verify = git_config_bool(var, value);
I think this patch is wrong.
You just broke existing repositories with:
	[http]
        	sslverify
to set it to true.
Previous: Christian Couder
Message 3 of 3 in “http.c: guard config parser from value=NULL”
  1. http.c: guard config parser from value=NULLGovind Salinas, Feb 9, 2008
  2. Christian CouderFeb 9, 2008
  3. Junio C HamanoFeb 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.