From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 09 Feb 2008 21:09:34 GMT
Subject: Re: [PATCH] http.c: guard config parser from value=NULL
Message-ID: <7vabm9et0x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <5d46db230802081639n78aab3b2s1e83ab9c4afc6a38@mail.gmail.com>

"Govind Salinas" <blix@sophiasuchtig.com> writes:

> Signed-off-by: Govind Salinas <blix@sophiasuchtig.com>
> ---
>  http.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/http.c b/http.c
> index d2c11ae..0a2c1c8 100644
> --- a/http.c
> +++ b/http.c
> @@ -92,6 +92,9 @@ static void process_curl_messages(void)
>
>  static int http_options(const char *var, const char *value)
>  {
> +	if (!value)
> +		return git_default_config(var, value);
> +
>  	if (!strcmp("http.sslverify", var)) {
>  		if (curl_ssl_verify == -1) {
>  			curl_ssl_verify = git_config_bool(var, value);

I think this patch is wrong.

You just broke existing repositories with:

	[http]
        	sslverify

to set it to true.