git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] count-objects: add human-readable size option

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 15, 2008, 00:10 UTC
Message-ID
<7vabffcf4e.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<48A4C521.6090507@griep.us>
Marcus Griep <marcus@griep.us> writes:
Show 6 quoted lines
> Petr Baudis wrote:
>>> +-H::
>> 
>> Can you guess what would I bug you about? ;-)
>
> If we get '-h', I'll submit another patch :-P

Wasn't the problem about documenting the addition of pack size, which is not about this human-readable option?

Show 8 quoted lines
>> If it's non-human-readable anyway, why are you dividing this by 1024? At
>> any rate, it is not obvious at all that the size-pack is not actually
>> size-pack but size-pack/1024. You should either add the (fixed) unit
>> string behind or name it size-pack-kb - or just not divide it at all?
>
> I divide by 1024 here because the loose object size is reported in KiB.
> The total that ends up in size_pack is in B, hence to be consistent, I
> report the pack size in KiB as well.
I thought this part was ok without room for dispute.
Previous: Marcus GriepNext: Petr Baudis
Message 7 of 18 in “count-objects size and strbuf human-readable”
  1. 0/3 count-objects size and strbuf human-readableMarcus Griep, Aug 14, 2008
  2. 1/3 count-objects: Add total pack size to verbose outputMarcus Griep, Aug 14, 2008
  3. 2/3 strbuf: Add method to convert byte-size to human readable formMarcus Griep, Aug 14, 2008
  4. 3/3 count-objects: add human-readable size optionMarcus Griep, Aug 14, 2008
  5. Petr BaudisAug 14, 2008
  6. Marcus GriepAug 14, 2008
  7. Junio C HamanoAug 15, 2008
  8. Petr BaudisAug 14, 2008
  9. Junio C HamanoAug 14, 2008
  10. Petr BaudisAug 14, 2008
  11. Junio C HamanoAug 14, 2008
  12. Marcus GriepAug 15, 2008
  13. Marcus GriepAug 15, 2008
  14. Shawn O. PearceAug 15, 2008
  15. 1/3 count-objects: Add total pack size to verbose outputMarcus Griep, Aug 15, 2008
  16. 2/3 strbuf: Add method to convert byte-size to human readable formMarcus Griep, Aug 15, 2008
  17. 3/3 count-objects: add human-readable size optionMarcus Griep, Aug 15, 2008
  18. 1/3 count-objects: Add total pack size to verbose outputMarcus Griep, Aug 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.