Re: [PATCH v2 2/3] strbuf: Add method to convert byte-size to human readable form

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 15, 2008, 00:52 UTC
Message-ID: <20080815005212.GI3782@spearce.org>
In-Reply-To: <48A4D1DD.9060202@griep.us>

Marcus Griep <marcus@griep.us> wrote:

Show 6 quoted lines

> Petr Baudis wrote:
> > Whitespace damage? Also at a lot of other places in your patch.
> 
> No damage.  It was indicated to me that 80-ish was the preferred width, so
> I was trying to follow that.  If that's not true in the C sources, I'll
> bundle things up a bit more.

The sources are roughly:

- 80 columns wide, try not to make it wider;

- ident leading part of line with _TABs_ not spaces;

- tab width in your editor should be 8, so you see when you
  are too wide;

- one tab per block in C;

- don't align variable names in declarations;

- use {} only around complex statements;

... there's more. But if you follow the above along with "dammit, make it match the code above and below where you are inserting" you get it pretty quick.

-- 
Shawn.