Re: [PATCH] git remote update: New option --prune (-p)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 2, 2009, 18:06 UTC
Message-ID: <7vab6zexq7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090402134414.GB26699@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think it makes sense under update as pruning is really just a
> different (and perhaps slightly more dangerous) form of update.
> Generally I would only want to run prune after having run update, so
> combining them makes sense from a workflow perspective.

I agree with you that "oh by the way please prune as well" makes perfect sense, but I actually would even go stronger than that---if we _were_ adding this command today, I would probably make "update" prune by default, perhaps with an option to skip the pruning step.

I gave the patch an only cursory look, so I wouldn't comment on the implementation; two things I would look at in the code would be if it makes two connections to the remote to learn the same information (which would be bad) and if it skips the pruning stage if the update stage failed (which would probably be a sane precaution).