Re: [PATCH] git remote update: New option --prune (-p)
- From
Finn Arne Gangstad <finnag@pvv.org>
- Date
- Apr 2, 2009, 20:18 UTC
- Message-ID
- <20090402201803.GA5397@pvv.org>
- In-Reply-To
- <7vab6zexq7.fsf@gitster.siamese.dyndns.org>
On Thu, Apr 02, 2009 at 11:06:56AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> [...] > > I gave the patch an only cursory look, so I wouldn't comment on the > implementation; two things I would look at in the code would be if it > makes two connections to the remote to learn the same information (which > would be bad)
How bad? git remote update execs "git fetch <remote>" to do the fetching part, and after that the information is lost of course. It might be possible to do a --prune option to fetch instead, and just use that directly.
> and if it skips the pruning stage if the update stage failed > (which would probably be a sane precaution).
Yes, this should be fixed.
- Finn Arne