Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2010, 21:26 UTC
- Message-ID
- <7vaatmooeb.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <201004011024.50615.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 11 quoted lines
>> ifndef NO_PERL
>> - $(RM) gitweb/gitweb.cgi
>> + $(RM) gitweb/gitweb.{cgi,min.*}
>> $(MAKE) -C perl clean
>> endif
>
> Minor nit: this would be first line that uses {a,b} shell glob
> construct. Why not write it as:
>
> - $(RM) gitweb/gitweb.cgi
> + $(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*Very good point and it is not a "minor nit"; I cannot apply the patch without your fix.
My understanding is that you Ack 1 (with this fix), 2 (with another paragraph in the log message), and 5. Eric Acked 4 and 6 needs to be reworked. I wonder if anybody has comments on 3; I didn't look very closely at it, but it looked sane to me.
With that understanding, I'll queue the whole thing to 'pu', so that they can be reworked and replaced before hitting 'next'.
Thanks, all.