Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 1, 2010, 08:24 UTC
Message-ID: <201004011024.50615.jnareb@gmail.com>
In-Reply-To: <4BB430A0.7040700@mailservices.uwaterloo.ca>

On Thu, 1 April 2010, Mark Rada wrote:

> Signed-off-by: Mark Rada <marada@uwaterloo.ca>

For what it's worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>

Show 12 quoted lines

> diff --git a/Makefile b/Makefile
> index 6d73a8c..5384d33 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2089,7 +2089,7 @@ clean:
>  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>  	$(MAKE) -C Documentation/ clean
>  ifndef NO_PERL
> -	$(RM) gitweb/gitweb.cgi
> +	$(RM) gitweb/gitweb.{cgi,min.*}
>  	$(MAKE) -C perl clean
>  endif

Minor nit: this would be first line that uses {a,b} shell glob construct. Why not write it as:

  -	$(RM) gitweb/gitweb.cgi
  +	$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*

-- 
Jakub Narebski
Poland