Re: [PATCH] Improved error messages when temporary file creation fails

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2010, 20:47 UTC
Message-ID: <7vaak2hkqj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101218200516.GA10031@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Hi again,
>
> Arnout Engelen wrote:
>
>> Updated version of the patch
>
> Almost there.  Some remaining nits from my pov:
>
>> , taking into account the feedback from this 
>> thread.
> [...]
>
> This text above the "---" becomes part of the log message when a patch
> is committed to git.git, so it is best to make it self-contained.  The
> usual advice is "describe the current behavior, why the proposed
> behavior is better, and then how the proposed behavior is achieved."

Thanks, Jonathan.

The important part of self-containedness is that people who are reading the resulting commit and the history that contains it should not have to unnecessarily refer to outside resources, especially the previous rounds that weren't satisfactory. The comparison with previous rounds however is a very valuable resource for reviewers on the mailing list, so don't remove what you wrote there, but move it below "---" lines.