Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 15, 2012, 18:09 UTC
- Message-ID
- <7vaa04bg5q.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120615162136.GC4572@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> PS There seem to be some other similar declarations: at least > cmd_upload_tar and cmd_pickaxe.
Thanks.
$ sed -ne 's/^extern int \(cmd_[^(]*\)(.*/\1/p' builtin.h | sort >/var/tmp/1 $ nm -g git| sed -ne 's/^[0-9a-f]* T cmd_/cmd_/p' | sort > /var/tmp/2 $ comm -3 /var/tmp/[12]
finds only the two you mentioned, so how about doing it this way?
-- >8 -- From: Luka Perkov <lists@lukaperkov.net> Date: Thu, 14 Jun 2012 22:23:37 +0200 Subject: [PATCH] builtin.h: remove unused cmd_<foo> declarations
These were left in builtin.h after they were converted into stand-alone programs or removed after experiments finished.
Signed-off-by: Luka Perkov <lists@lukaperkov.net> Helped-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/builtin.h b/builtin.h index 20427d2..3e44816 100644 --- a/builtin.h +++ b/builtin.h @@ -58,7 +58,6 @@ extern int cmd_gc(int argc, const char **argv, const char *prefix); extern int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix); extern int cmd_grep(int argc, const char **argv, const char *prefix); extern int cmd_help(int argc, const char **argv, const char *prefix); -extern int cmd_http_fetch(int argc, const char **argv, const char *prefix); extern int cmd_init_db(int argc, const char **argv, const char *prefix); extern int cmd_log(int argc, const char **argv, const char *prefix); extern int cmd_log_reflog(int argc, const char **argv, const char *prefix); @@ -76,7 +75,6 @@ extern int cmd_mktree(int argc, const char **argv, const char *prefix); extern int cmd_mv(int argc, const char **argv, const char *prefix); extern int cmd_name_rev(int argc, const char **argv, const char *prefix); extern int cmd_pack_objects(int argc, const char **argv, const char *prefix); -extern int cmd_pickaxe(int argc, const char **argv, const char *prefix); extern int cmd_prune(int argc, const char **argv, const char *prefix); extern int cmd_prune_packed(int argc, const char **argv, const char *prefix); extern int cmd_push(int argc, const char **argv, const char *prefix); @@ -104,7 +102,6 @@ extern int cmd_unpack_objects(int argc, const char **argv, const char *prefix); extern int cmd_update_index(int argc, const char **argv, const char *prefix); extern int cmd_update_ref(int argc, const char **argv, const char *prefix); extern int cmd_upload_archive(int argc, const char **argv, const char *prefix); -extern int cmd_upload_tar(int argc, const char **argv, const char *prefix); extern int cmd_verify_tag(int argc, const char **argv, const char *prefix); extern int cmd_version(int argc, const char **argv, const char *prefix); extern int cmd_whatchanged(int argc, const char **argv, const char *prefix);
-- 1.7.11.rc3.30.g3bdace2