Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch

From: Jeff King <peff@peff.net>
Date: Jun 15, 2012, 18:16 UTC
Message-ID: <20120615181636.GA14843@sigill.intra.peff.net>
In-Reply-To: <7vaa04bg5q.fsf@alter.siamese.dyndns.org>

On Fri, Jun 15, 2012 at 11:09:53AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > PS There seem to be some other similar declarations: at least
> >    cmd_upload_tar and cmd_pickaxe.
> 
> Thanks.
> 
> $ sed -ne 's/^extern int \(cmd_[^(]*\)(.*/\1/p' builtin.h | sort >/var/tmp/1
> $ nm -g git| sed -ne 's/^[0-9a-f]* T cmd_/cmd_/p' | sort > /var/tmp/2
> $ comm -3 /var/tmp/[12]
> 
> finds only the two you mentioned, so how about doing it this way?

I used a slightly grosser grep that looked in "*.c", and come up with only those 2. Patch looks good to me.

-Peff