git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Support builds when sys/param.h is missing

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 15, 2012, 17:53 UTC
Message-ID
<7va9tfurq1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAEvUa7kZE-p0oVV+JpXY4y-=ieB-=THTrO4hxzZsFYhLvgvbFw@mail.gmail.com>
David Michael <fedora.dm0@gmail.com> writes:
Show 9 quoted lines
> On Fri, Dec 14, 2012 at 6:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I have this suspicion that nobody would notice if we simply stopped
>> including the header.
>
> While I'm not aware of any subtleties it could be causing on other
> platforms, it does seem fine to drop sys/param.h on my test GNU/Linux
> systems.
>
> I can resend the series and just remove the include, if preferred.

I am sure the patch as posted is much safer, but I was hoping that folks on non-Linux platforms may say "I tried to compile with the include removed, and I get identical binaries from before". Until that happens, I would prefer queuing your patch as-is.

Thanks.
Previous: David Michael
Message 4 of 4 in “Support builds when sys/param.h is missing”
  1. 1/4 Support builds when sys/param.h is missingDavid Michael, Dec 14, 2012
  2. Junio C HamanoDec 14, 2012
  3. David MichaelDec 15, 2012
  4. Junio C HamanoDec 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.