From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 15 Dec 2012 17:53:42 GMT
Subject: Re: [PATCH 1/4] Support builds when sys/param.h is missing
Message-ID: <7va9tfurq1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAEvUa7kZE-p0oVV+JpXY4y-=ieB-=THTrO4hxzZsFYhLvgvbFw@mail.gmail.com>

David Michael <fedora.dm0@gmail.com> writes:

> On Fri, Dec 14, 2012 at 6:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I have this suspicion that nobody would notice if we simply stopped
>> including the header.
>
> While I'm not aware of any subtleties it could be causing on other
> platforms, it does seem fine to drop sys/param.h on my test GNU/Linux
> systems.
>
> I can resend the series and just remove the include, if preferred.

I am sure the patch as posted is much safer, but I was hoping that
folks on non-Linux platforms may say "I tried to compile with the
include removed, and I get identical binaries from before".  Until
that happens, I would prefer queuing your patch as-is.

Thanks.