Re: [PATCH v2 0/5] Write a good 'git stash store' for autostash

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2013, 14:26 UTC
Message-ID: <7va9mssr88.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1371205924-8982-1-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> So, I've taken Junio's suggestion and designed a proper command-line
> interface for 'git stash store' in this iteration:
>
>   git stash store [-m <message>] [-e <error>] <commit>

I am perplexed; that would not something I _would_ design or suggest. The "-e <error>" looks especially odd, in that "-e" usually refers to something the command evaluates (e.g. sed, perl), but more importantly if the caller wants a custom error message, normal programmers would do

	command || die "my custom error message"

and if "command" wants to show its own error by default, perhaps do

	command --quiet || die "my custom error message"