git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/4] config: improve support for http.<url>.* settings

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 20, 2013, 00:35 UTC
Message-ID
<7va9lit6du.fsf@alter.siamese.dyndns.org>
In-Reply-To
<2544648C-9660-48F0-888A-E78E31477A89@gmail.com>
"Kyle J. McKay" <mackyle@gmail.com> writes:
> If you mean for all the strchr etc. calls, multiple tables would be
> required since URL_SCHEME_CHARS and URL_HOST_CHARS partially overlap,

The entries of the table could be at least 8-bit wide, so there shouldn't be any problem, should there?

> but it could be done.  Is the speed of strchr that much of a concern?
> The code will only be invoked for http.<url>.* option settings in any
> case and I expect the user would have to set an awfully large number
> of those to even begin to notice.

We can start slow and then optimize, but I suspect that there are sufficient number of people who are into micro-optimizing, and such a slow implementation may quickly be replaced.

Previous: Kyle J. McKayNext: Kyle J. McKay
Message 8 of 10 in “config: add support for http.<url>.* settings”
  1. 0/4 config: add support for http.<url>.* settingsKyle J. McKay, Jul 19, 2013
  2. 1/4 config: add support for http.<url>.* settingsKyle J. McKay, Jul 19, 2013
  3. Junio C HamanoJul 19, 2013
  4. Kyle J. McKayJul 19, 2013
  5. 2/4 config: improve support for http.<url>.* settingsKyle J. McKay, Jul 19, 2013
  6. Junio C HamanoJul 19, 2013
  7. Kyle J. McKayJul 19, 2013
  8. Junio C HamanoJul 20, 2013
  9. 3/4 tests: add new test for the url_normalize functionKyle J. McKay, Jul 19, 2013
  10. 4/4 config: allow http.<url>.* any user matchingKyle J. McKay, Jul 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.