From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 20 Jul 2013 00:35:57 GMT
Subject: Re: [PATCH v6 2/4] config: improve support for http.<url>.* settings
Message-ID: <7va9lit6du.fsf@alter.siamese.dyndns.org>
In-Reply-To: <2544648C-9660-48F0-888A-E78E31477A89@gmail.com>

"Kyle J. McKay" <mackyle@gmail.com> writes:

> If you mean for all the strchr etc. calls, multiple tables would be
> required since URL_SCHEME_CHARS and URL_HOST_CHARS partially overlap,

The entries of the table could be at least 8-bit wide, so there
shouldn't be any problem, should there?

> but it could be done.  Is the speed of strchr that much of a concern?
> The code will only be invoked for http.<url>.* option settings in any
> case and I expect the user would have to set an awfully large number
> of those to even begin to notice.

We can start slow and then optimize, but I suspect that there are
sufficient number of people who are into micro-optimizing, and such
a slow implementation may quickly be replaced.