Re: [PATCH] send-email: squelch warning from Net::SMTP::SSL

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2013, 16:01 UTC
Message-ID: <7va9l51hkn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <kstfht$p0e$1@ger.gmane.org>

Colin Guthrie <gmane@colin.guthr.ie> writes:

Show 14 quoted lines

> For what it's worth, after upgrading here, I got this error at the
> server side:
>
> Jul 26 10:15:41 foo.example.com postfix/smtpd[7736]: warning: TLS
> library problem: 7736:error:14094418:SSL routines:SSL3_READ_BYTES:tlsv1
> alert unknown ca:s3_pkt.c:1256:SSL alert number 48:
>
>
> This is because my postfix doesn't have a ca bundle configured but all
> other mail clients have been fine before.
>
> With the original patch here I could continue.
>
> I'd really love to see an option to set this to none in the .gitconfig,

Isn't that what the final patch committed under Ram's name implements?

    sendemail.smtpsslcertpath::
           Path to ca-certificates (either a directory or a single file).
           Set it to an empty string to disable certificate verification.

or have we missed your use case?

> but agree with the principle that it should be one by default and the
> setting should over ride that.