[PATCH] send-email: squelch warning from Net::SMTP::SSL
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jul 5, 2013, 10:18 UTC
- Message-ID
- <1373019511-13232-1-git-send-email-artagnon@gmail.com>
Due to a recent change in the Net::SMTP::SSL module, send-email emits the following ugly warning everytime a email is sent via SSL:
******************************************************************* Using the default of SSL_verify_mode of SSL_VERIFY_NONE for client is deprecated! Please set SSL_verify_mode to SSL_VERIFY_PEER together with SSL_ca_file|SSL_ca_path for verification. If you really don't want to verify the certificate and keep the connection open to Man-In-The-Middle attacks please set SSL_verify_mode explicitly to SSL_VERIFY_NONE in your application. *******************************************************************
Fix this by explicitly specifying SSL_verify_mode => SSL_VERIFY_NONE in Net::SMTP::SSL->start_SSL().
Helped-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- git-send-email.perl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl index ecbf56f..758100d 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1193,10 +1193,12 @@ X-Mailer: git-send-email $gitversion Debug => $debug_net_smtp); if ($smtp_encryption eq 'tls' && $smtp) { require Net::SMTP::SSL; + use IO::Socket::SSL qw(SSL_VERIFY_NONE); $smtp->command('STARTTLS'); $smtp->response(); if ($smtp->code == 220) { - $smtp = Net::SMTP::SSL->start_SSL($smtp) + $smtp = Net::SMTP::SSL->start_SSL($smtp, + SSL_verify_mode => SSL_VERIFY_NONE) or die "STARTTLS failed! ".$smtp->message; $smtp_encryption = ''; # Send EHLO again to receive fresh
-- 1.8.3.2.722.g3244e19.dirty