Re: Comments on recursive merge..
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 9, 2005, 01:42 UTC
- Message-ID
- <7v8xvyd2bh.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0511081716450.3247@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 7 quoted lines
> It does: > > struct commit *commit = pop_one_commit(list_p); > int still_interesting = !!interesting(*list_p); > > in that order: it looks whether there are any interesting commits left > _after_ it has popped the top-of-stack.
Ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh. You are right.
The problem is most of the time hidden, because we usually do one extra round (extra usually starts from 0 and we break out after we say "not interesting anymore" and extra < 0).
Obviously, I was not thinking clearly.