Re: [RFD] gitweb configuration

From: Junio C Hamano <junkio@cox.net>
Date: Jun 18, 2006, 09:40 UTC
Message-ID: <7v8xnu3iol.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <e735d7$6dq$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 6 quoted lines

> Timo Hirvonen wrote:
>
>> Just use "git command" and you don't have to know $gitexecdir.
>
> First, 'git' might be not in PATH for the webserver user which runs
> gitweb.cgi.

For that we would have a chicken-and-egg problem if we make configuration mechanism based on git-repo-config, so I would say per-site customization is needed somehow.

Hardcoding the path into gitweb.cgi could be one way. Hardcoding the path to gitweb per-site configuration file and implement the logic to parse the configuration file without using git-repo-config would be another. Even if you wanted to use "git --exec-path" to bootstrap, not having "git" in the path would make it, eh, cumbersome.

My gut feeling is that it is sensible to assume git is on everybody's path -- after all the site is running gitweb and majority would be using binary packaged distribution, so git would be installed somewhere sensible and accessible.

So I am with Timo on this one, except that in some cases munging gitweb.cgi script itself might be needed if the installation chose to hide git somewhere inaccessible from ordinary users.