Re: [RFD] gitweb configuration

From: Petr Baudis <pasky@suse.cz>
Date: Jun 18, 2006, 13:04 UTC
Message-ID: <20060618130401.GM2609@pasky.or.cz>
In-Reply-To: <7v64iy505x.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Sun, Jun 18, 2006 at 10:38:02AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 17 quoted lines

> "Martin Langhoff" <martin.langhoff@gmail.com> writes:
> 
> > On 6/18/06, Jakub Narebski <jnareb@gmail.com> wrote:
> >> So GIT_CONFIG would be ~/.gitconfig, and GIT_CONFIG_LOCAL would be
> >> $GIT_DIR/config or what?
> >
> > I don't quite follow why gitweb needs a GIT_CONFIG_LOCAL defined.
> > Given that it works in a CGI environment, it should read
> > $GIT_DIR/config by default, and $GIT_CONFIG if set (from httpd.conf).
> 
> I am not Pasky, but I think the intent of the patch is to run
> "git repo-config" with GIT_CONFIG pointing at /etc/gitweb.conf
> to obtain server-wide configuration (e.g. finding out where
> repositories are) and then when serving individual repository
> (i.e. after we set up GIT_DIR to point at it) run "git
> repo-config" without GIT_CONFIG to read per-repository
> configuration.  That way we can reuse the configuration parser.

Yes, if $GIT_CONFIG is set, git should be guaranteed to read _no_ config file except $GIT_CONFIG. The intent of $GIT_LOCAL_CONFIG was to make it possible to just override the per-repo configfile location, but it just felt nice to have - I don't insist on it so if people think it's useless additional complexity I'm happy to say that one goodbye.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.