Re: [PATCH] Create 'git gc' to perform common maintenance operations.

From: Junio C Hamano <junkio@cox.net>
Date: Dec 27, 2006, 09:10 UTC
Message-ID: <7v8xgt9026.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061227083328.GD23022@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

Show 14 quoted lines

> Junio C Hamano <junkio@cox.net> wrote:
>> Shawn Pearce <spearce@spearce.org> writes:
>> 
>> > I don't care either way.  60 days may be too long for some users,
>> > but for others it may be nice to have.  I think the two defaults
>> > should match just because.  Feel free to edit my patch before
>> > applying to be whatever 'git-reflog expire' uses if you want.
>> 
>> I think the built-in git-reflog should be updated to honor the
>> configuration in the absense of command line options; if we do
>> that git-gc.sh does not even have to call repo-config anymore.
>
> Sure, but then maybe the configuration options shouldn't be
> 'gc.reflog*' but instead 'reflog.*'.

Actually I think gc.reflog, gc.rerere and friends make more sense. In other words, I think it is better to match the configuration group to what the end user primarily sees, which is "gc"; "reflog expire" and "rerere gc" are implementation details of it.