Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

From: Junio C Hamano <junkio@cox.net>
Date: May 19, 2007, 20:00 UTC
Message-ID: <7v8xbkwpl2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070519140521.GA4085@planck.djpig.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

Show 6 quoted lines

>> But I certainly don't intend to do all the tests in one big file which
>> will become rather large over time. If you're concerned with code
>> duplication, maybe I should move the code to a separate file and source
>> it from there?
>
> Still waiting on a comment here...

Well, It seems that all of our foreign SCM tests tends to be slower than other tests, so I would be happier if a single run of one test covers everything we would want to cover, when I run "make test", rather than having multiple set-up steps that are identical in two different tests. So in that sense, I was not talking about code duplication which can be solved by splitting the duplicated part into a separate file and sourcing it from two scripts -- that is not a solution.

Another thing we would need to decide (with Eric who has the same issue) is how to structure the tests that try daemons. We worked it around by using :fork: for the first cvsserver test, but we would eventually want the real pserver test as well.