Re: [PATCH (amend)] cvsserver: Add test cases for config file handling

From: Frank Lichtenheld <frank@lichtenheld.de>
Date: May 19, 2007, 14:05 UTC
Message-ID: <20070519140521.GA4085@planck.djpig.de>
In-Reply-To: <20070514125915.GB5272@planck.djpig.de>

On Mon, May 14, 2007 at 02:59:16PM +0200, Frank Lichtenheld wrote:

Show 20 quoted lines

> On Sun, May 13, 2007 at 01:04:15PM -0700, Junio C Hamano wrote:
> > Frank Lichtenheld <frank@lichtenheld.de> writes:
> > 
> > > Add a few test cases for the config file parsing
> > > done by git-cvsserver.
> > >
> > > Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> > > ---
> > >  t/t9420-git-cvsserver-config.sh |  109 +++++++++++++++++++++++++++++++++++++++
> > >  1 files changed, 109 insertions(+), 0 deletions(-)
> > >  create mode 100755 t/t9420-git-cvsserver-config.sh
> > 
> > Do we really need a separate test script that does quite similar setup?
> 
> Right now, probably not.
> 
> But I certainly don't intend to do all the tests in one big file which
> will become rather large over time. If you're concerned with code
> duplication, maybe I should move the code to a separate file and source
> it from there?

Still waiting on a comment here...

Gruesse,

-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/