Re: git-send-pack: broken handling of ref specs with wildcards

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2007, 06:33 UTC
Message-ID: <7v8xavlzu0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0706072356220.4046@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

> On Fri, 8 Jun 2007, Alex Riesen wrote:
>
>> Try something like this:
>> 
>>     git-send-pack --remote=origin --thin /some/other/repo \
>>     'refs/heads/*:refs/remotes/child/*'
>> 
>> The result looks broken: the sent reference are created not in
>> refs/remotes/child/ but just in refs/heads/ of /some/other/repo.
>
> I had the impression that it was git-push, a porcelain, which handles 
> refspec wildcards, not send-pack, which is plumbing.

Well, I do not think it is wrong per-se if plumbing send-pack starts understanding 'a/*:b/*'. Earlier it only understood concrete refspecs, and such a refspec that has asterisks cannot be concrete, as '*' is an invalid char in a refname. So there is no risk of confusion.

That is, as long as it is done right, which was not true in this case.