Re: [PATCH] Fix push with refspecs containing wildcards

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 8, 2007, 09:13 UTC
Message-ID: <20070608091332.GA2429@steel.home>
In-Reply-To: <7vodjqlwnc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano, Fri, Jun 08, 2007 09:42:47 +0200:

Show 6 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Sending a fix is a good thing, but whenever doing one, could
> > people please also do a testcase that demonstrates the original
> > bug, and also a demonstration that the fix does not introduce
> > regression?

Sorry. I actually have a test script I used to develop the fix, but somehow missed to send it.

Show 11 quoted lines

> > For this one, obviously a test for push that uses such wildcard
> > ref is needed but at the same time we would want a test for push
> > that does _not_ use a wildcard, fetch that uses a wildcard, and
> > a fetch that does not use a wildcard.
> 
> How about this?
> ---
> 
>  t/t5516-fetch-push.sh |   82 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 82 insertions(+), 0 deletions(-)
>

Gratefully-Acked-by: Alex Riesen <raa.lkml@gmail.com>