git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>"

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2008, 05:29 UTC
Message-ID
<7v8wvlmf6k.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1217277453.488e2e0db0f41@webmail.nextra.at>
Johannes Sixt <johannes.sixt@telecom.at> writes:
Show 9 quoted lines
> Zitat von Steffen Prohaska <prohaska@zib.de>:
> ...
>> The patch below might fix the problem by always calling 'bin/git'
>> for builtin commands.  The computation in system_path() would
>> always start from 'bin' and thus yields predictable results.  I
>> am not sure however if it fully solves the problem because other
>> code paths might run the dashed forms directly.
>
> This paragraph should go into the commit message.
> ...
> Your patches make a lot of sense.

I was almost going to suggest doing this everywhere not just on Windows, but execv_git_cmd() on the POSIX side already runs "git" wrapper, so this patch makes them in line, finally.

Show 9 quoted lines
>> -- 8< --
>> We prefer running the dashless form, so we should use it in
>> MinGW's start_command(), too.
>>
>> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
>
> Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
>
> -- Hannes
Previous: Steffen ProhaskaNext: Johannes Sixt
Message 10 of 11 in “Refactor, adding prepare_git_cmd(const char **argv)”
  1. 1/2 Refactor, adding prepare_git_cmd(const char **argv)Steffen Prohaska, Jul 28, 2008
  2. [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>"Steffen Prohaska, Jul 28, 2008
  3. Junio C HamanoJul 28, 2008
  4. Junio C HamanoJul 28, 2008
  5. Johannes SchindelinJul 28, 2008
  6. Johannes SixtJul 28, 2008
  7. Steffen ProhaskaJul 29, 2008
  8. 2/2 run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)Steffen Prohaska, Jul 29, 2008
  9. [FOR DEBUGGING] Stop installing BUILT_INSSteffen Prohaska, Jul 29, 2008
  10. Junio C HamanoJul 29, 2008
  11. Johannes SixtJul 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.