Re: [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>"
- From
Johannes Sixt <johannes.sixt@telecom.at>
- Date
- Jul 29, 2008, 08:39 UTC
- Message-ID
- <1217320797.488ed75ddb14b@webmail.nextra.at>
- In-Reply-To
- <7v8wvlmf6k.fsf@gitster.siamese.dyndns.org>
Zitat von Junio C Hamano <gitster@pobox.com>:
Show 18 quoted lines
> Johannes Sixt <johannes.sixt@telecom.at> writes: > > > Zitat von Steffen Prohaska <prohaska@zib.de>: > > ... > >> The patch below might fix the problem by always calling 'bin/git' > >> for builtin commands. The computation in system_path() would > >> always start from 'bin' and thus yields predictable results. I > >> am not sure however if it fully solves the problem because other > >> code paths might run the dashed forms directly. > > > > This paragraph should go into the commit message. > > > ... > > Your patches make a lot of sense. > > I was almost going to suggest doing this everywhere not just on Windows, > but execv_git_cmd() on the POSIX side already runs "git" wrapper, so this > patch makes them in line, finally.
For this reason I'm in favor of these patches. I didn't run the full test suite with them, yet, (you know, that takes a while on Windows), but "make *clone* *fetch* *pack*" worked out OK.
-- Hannes