Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 27, 2008, 11:53 UTC
Message-ID: <7v8wq1esvo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1230368596-6865-1-git-send-email-dato@net.com.org.es>

Adeodato Simó <dato@net.com.org.es> writes:

Show 5 quoted lines

> +commit.signoff::
> +	If set, 'git commit' will behave as if '-s' option was given.
> +	Please use this option with care: by enabling it, you're stating
> +	that all your commits will invariably meet the S-o-b
> +	requirements for any project you send patches to. It's probably

This is true only if you set it in your global configuration. A more sane usage would be to have it per repository as you recommend in a later sentence, and "for any project" part is untrue when the reader does so.

Show 11 quoted lines

> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index b5d81be..abab839 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -96,7 +96,8 @@ OPTIONS
>  -s::
>  --signoff::
>  	Add Signed-off-by line by the committer at the end of the commit
> -	log message.
> +	log message. This overrides the `commit.signoff` configuration
> +	variable.

Good and careful thinking.  I like it.