[PATCH] Add a commit.signoff configuration variable to always use --signoff
- From
Adeodato Simó <dato@net.com.org.es>
- Date
- Dec 27, 2008, 09:03 UTC
- Message-ID
- <1230368596-6865-1-git-send-email-dato@net.com.org.es>
- In-Reply-To
- <7v63l6f1mc.fsf@gitster.siamese.dyndns.org>
Signed-off-by: Adeodato Simó <dato@net.com.org.es> ---
* Junio C Hamano [Sat, 27 Dec 2008 00:44:59 -0800]:
> > +commit.signoff:: > > + If set, 'git-commit' will always add a Signed-off-by line.
> It is not a big deal, but my first reaction to the above was "S-o-b by > whom? It misses details and does not say where to find them".
> How about "if set, 'git commit' will behave as if '-s' option was given", > so that we can leave the details of whose S-o-b line to generate and such > to the description of "git commit -s" manual page?
Changed.
> > I'll send an amended patch (or should I send an incremental/extra > > one instead?)
I didn't get an answer to this, so I'm sending an amended one, hoping that's the correct thing to do in this land.
Show 6 quoted lines
> Another problem that you seem to have missed about M-F-T is that while you > solicited responses from general public by CC'ing the list (which allowed > me to respond to you), by forcing the response go only to the list, you > excluded people on the To: and Cc: list of your original message from my > response. You required them to be subscribed to the list, if they want to > be kept in the loop.
No, not really, because Mutt will add to the M-F-T header all addresses that appear on the To or Cc headers.
Documentation/config.txt | 9 +++++++++ Documentation/git-commit.txt | 3 ++- builtin-commit.c | 5 +++++ 3 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt index 52786c7..4d0a79b 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -591,6 +591,15 @@ color.ui:: commit.template:: Specify a file to use as the template for new commit messages. +commit.signoff:: + If set, 'git commit' will behave as if '-s' option was given. + Please use this option with care: by enabling it, you're stating + that all your commits will invariably meet the S-o-b + requirements for any project you send patches to. It's probably + best to only use it from your private repositories' .git/config + file, and only for projects who require a S-o-b as proof of + provenance of the patch, and not of its correctness or quality. + diff.autorefreshindex:: When using 'git-diff' to compare with work tree files, do not consider stat-only change as changed. diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index b5d81be..abab839 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -96,7 +96,8 @@ OPTIONS -s:: --signoff:: Add Signed-off-by line by the committer at the end of the commit - log message. + log message. This overrides the `commit.signoff` configuration + variable. -n:: --no-verify:: diff --git a/builtin-commit.c b/builtin-commit.c index e88b78f..fc09539 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -929,6 +929,11 @@ static int git_commit_config(const char *k, const char *v, void *cb) if (!strcmp(k, "commit.template")) return git_config_string(&template_file, k, v); + if (!strcmp(k, "commit.signoff")) { + signoff = git_config_bool(k, v); + return 0; + } + return git_status_config(k, v, cb); }
-- 1.6.1.307.g07803