git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: Remove usage of deprecated Python "has_key" method

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 29, 2010, 04:08 UTC
Message-ID
<7v8w9bkbwo.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100328215442.GA31195@gmail.com>
David Aguilar <davvid@gmail.com> writes:
Show 20 quoted lines
> On Sun, Mar 28, 2010 at 09:38:54AM -0700, Junio C Hamano wrote:
>> David Aguilar <davvid@gmail.com> writes:
>> 
>> > "has_key" is a deprecated dictionary method in Python 2.6+.
>> > Simplify the sys.path manipulation for installed scripts by
>> > passing a default value to os.getenv().
>> 
>> It looks like the old code was replacing sys.path[0] but you are
>> prepending this.  Doesn't that change also make a difference?
>
> The original code replaced sys.path[0] which is ''
> (aka the current directory).  It's a little odd to
> rely on the 0th element being something that is safe
> to remove.
>
> By prepending the path we have the same intended effect without
> having to know that the 0th element is something that is
> safe to remove.
>
> Does removing '' break relative imports? (It might...)

That is exactly why I asked if it was an improvement that was not described in the log message.

I'll queue with Johan's Ack, perhaps rewording the message a bit. Thanks.

Previous: Tay Ray ChuanNext: Johan Herland
Message 5 of 6 in “Makefile: Remove usage of deprecated Python "has_key" method”
  1. Makefile: Remove usage of deprecated Python "has_key" methodDavid Aguilar, Mar 28, 2010
  2. Junio C HamanoMar 28, 2010
  3. David AguilarMar 28, 2010
  4. Tay Ray ChuanMar 29, 2010
  5. Junio C HamanoMar 29, 2010
  6. Johan HerlandMar 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.