Re: [PATCH] Makefile: Remove usage of deprecated Python "has_key" method

From: David Aguilar <davvid@gmail.com>
Date: Mar 28, 2010, 21:54 UTC
Message-ID: <20100328215442.GA31195@gmail.com>
In-Reply-To: <7vy6hc4d0h.fsf@alter.siamese.dyndns.org>

On Sun, Mar 28, 2010 at 09:38:54AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> David Aguilar <davvid@gmail.com> writes:
> 
> > "has_key" is a deprecated dictionary method in Python 2.6+.
> > Simplify the sys.path manipulation for installed scripts by
> > passing a default value to os.getenv().
> 
> It looks like the old code was replacing sys.path[0] but you are
> prepending this.  Doesn't that change also make a difference?

The original code replaced sys.path[0] which is '' (aka the current directory). It's a little odd to rely on the 0th element being something that is safe to remove.

By prepending the path we have the same intended effect without having to know that the 0th element is something that is safe to remove.

Does removing '' break relative imports? (It might...)

Due to the portability concerns with relative imports the recommendation is to always use absolute imports. Thus, this shouldn't hurt us in practice if we stick to absolute imports, but I figured I'd mention it as another reason why prepending might be preferred over replacing.

-- 
		David